Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version key word 'all' should not be allowed when using multiple version parameters #26

Closed
jordan2175 opened this issue Dec 12, 2017 · 5 comments

Comments

@jordan2175
Copy link

Section 3.5.1

The spec does not currently say anything about using the "all" keyword in addition to other keywords. The "all" keyword should be restricted from multiple version selectors... Examples:

?match[version]=all = OKAY
?match[version]=last,first = OKAY
?match[version]=last,all,first === THIS SHOULD BE ILLEGAL

@allant0
Copy link

allant0 commented Jan 23, 2018

i dont think this is really a breaking change. No one would implement all in this way so I think what you suggest is really just making the spec clearer and not 'breaking' in reality.

@jordan2175
Copy link
Author

jordan2175 commented Jan 23, 2018

This was discussed on the working call on 2018-01-23 and no one objected to make this normative text change. The proposed text was "the all key word MUST NOT be used with any other version key word or version parameter". The following people were on the working call: Bret Jordan, Trey Darley, John-Mark Gurney, Sarah Kelley, Chris Ricard, Dave Lemire, Jason Keirstead, Nicholas Hayden, Richard Struse, Sunil Ravipati. Suggesting was made in section 3.5.1

@MarkDavidson
Copy link

Clarifying text might still be useful, but the version parameter isn't specified as a list, so this situation isn't possible.

@jordan2175
Copy link
Author

All parameters can be lists by using a comma.

@jordan2175
Copy link
Author

Text was added to 3.4.1 in the version row, "all" bullet. The whole text now reads:

all - requests all versions of an object. The all keyword MUST NOT be used with any other version parameters.

@jordan2175 jordan2175 added this to the TAXII-2.1-CSD01 milestone Feb 22, 2018
@jordan2175 jordan2175 added this to Done in TAXII-2.1 Feb 22, 2018
@jordan2175 jordan2175 removed this from Done in TAXII-2.1 Feb 22, 2018
@jordan2175 jordan2175 added this to Done in TAXII-2.1 Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
TAXII-2.1
  
Done
Development

No branches or pull requests

3 participants